-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added outlier detection tutorial #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Swagata,
regarding the SMOKE_TEST
:
It is a flag used by the testing pipelines, you have now used it in a way that parts of the notebooks are not tested at all, it should be more used in the way that every part is also run through in the tests but with a speedup, that means if SMOKE_TEST
is used, we use much less data, much less iterations and so fourth, of course the results will then not be significant but we can test the functionality of the notebook.
Please change it accordingly. The displayed output of the notebooks in the Repo should of course be from a complete run without smoke test, as it is also currently.
Best,
Johannes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
@jduerholt ,
Added outlier detection tutorials