Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all code styled and new lint rule added #65

Merged
merged 3 commits into from
Sep 19, 2017
Merged

all code styled and new lint rule added #65

merged 3 commits into from
Sep 19, 2017

Conversation

qvantor
Copy link
Contributor

@qvantor qvantor commented Sep 15, 2017

No description provided.

@qvantor qvantor self-assigned this Sep 15, 2017
@coveralls
Copy link

coveralls commented Sep 15, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 90.262% when pulling a52a126 on qvantor:code_style into effa88b on exonum:master.

@coveralls
Copy link

coveralls commented Sep 15, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 90.262% when pulling da72d9c on qvantor:code_style into effa88b on exonum:master.

@coveralls
Copy link

coveralls commented Sep 18, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 90.262% when pulling a52a126 on qvantor:code_style into effa88b on exonum:master.

This was referenced Sep 18, 2017
Closed
Closed
boguslavsky
boguslavsky approved these changes Sep 18, 2017
View reviewed changes
src/blockchain/block.js
}

return true
return uniqueValidators.length > validatorsTotalNumber * 2 / 3
Copy link
Contributor

@boguslavsky boguslavsky Sep 18, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick: this option is certainly shorter but previous one was a bit more understandable...

@qvantor qvantor merged commit a1d9d3d into exonum:master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boguslavsky boguslavsky boguslavsky approved these changes

@slowli slowli Awaiting requested review from slowli

Assignees

@qvantor qvantor

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qvantor @coveralls @boguslavsky