Merge pull request #147 from exonet/tsi/hotfix

Prevent notice if no comments are passed
exonet · Oct 24, 2023 · d896b89 · d896b89
2 parents 6d94e60 + 9351e89
commit d896b89
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/Helper.php b/src/Helper.php
@@ -35,7 +35,8 @@ public static function createResourceRecord(
                 return (new ResourceRecord())->setApiResponse($name);
             }
 
-            ['name' => $name, 'type' => $type, 'ttl' => $ttl, 'content' => $content, 'comments' => $comments] = $name;
+            $comments = $name['comments'] ?? [];
+            ['name' => $name, 'type' => $type, 'ttl' => $ttl, 'content' => $content] = $name;
         }
 
         $name = str_replace('@', $zoneName, $name);

diff --git a/tests/HelperTest.php b/tests/HelperTest.php
@@ -59,6 +59,27 @@ public function testWithArray(): void
         self::assertSame('rooti', $result->getComments()[1]->getAccount());
     }
 
+    public function testWithArrayWithoutOptionalFields(): void
+    {
+        $result = Helper::createResourceRecord(
+            'unit.test.',
+            [
+                'name' => '@',
+                'type' => RecordType::A,
+                'content' => ['127.0.0.1', '127.0.0.2'],
+                'ttl' => 1337,
+            ]
+        );
+
+        self::assertSame('unit.test.', $result->getName());
+        self::assertSame('A', $result->getType());
+        self::assertSame(1337, $result->getTtl());
+        self::assertCount(2, $result->getRecords());
+        self::assertSame('127.0.0.1', $result->getRecords()[0]->getContent());
+        self::assertSame('127.0.0.2', $result->getRecords()[1]->getContent());
+        self::assertEmpty($result->getComments());
+    }
+
     public function testWithApiResponse(): void
     {
         foreach (ZoneTest::API_RESPONSE['rrsets'] as $rrset) {