Support for private docker repositories/registries

[cmosh]

It would be nice if there was support for private registries/repos

[yamalight]

I assume you mean support for installing templates from private repos?

[cmosh]

Yes I think so, but to be clear let me explain my current use case because I'm not entirely sure. Which is this:

I have a private docker image on quay.io and I am using it as my base image in a Dockerfile I'd like to deploy. Something like this:

FROM quay.io/myaccount/mybaseimage
RUN foo bar
CMD ['run', 'foo','-bar']

But since the image is in a private docker registry the build fails, both the server I'm deploying to and my localhost are signed in and can pull the image, pre-pulling the image on the server does not help because exoframe tries to fetch the manifest on every build/deploy. So this is essentially a feature request

[yamalight]

Ah, well, that can be easily fixed. All you need to do is to login into quay with your docker daemon.
E.g. ssh into your server and run docker login quay.io, enter your credentials and try to deploy a service again - it should work.

[cmosh]

As I've already explained I'm logged in on both my local machine and on the server, it was the first thought I had, and to test I even pulled the image onto the server directly but it still gives the same error : unauthorized etc.

[yamalight]

The fact that you cannot pull it with docker daemon directly means that you are not logged into quay.io. I'd suggest looking into their docs or contacting their support about that.
Once you are able to pull images using docker daemon, exoframe should work as well

[cmosh]

I have been saying that I am logged in with the docker daemon, I can pull images with docker daemon on the server. I have even pulled and launched the images manually but I cannot deploy with exoframe. I have even tried both gitlab.com registry and codefresh registry.

I repeat I am logged in to the docker daemon and I have pulled private docker images. This does not seem to pass on the credentials to exoframe because deploys do not work.

[yamalight]

Uff, sorry, I'm a bit under the weather today and might not get the problem from the first try.
I think I finally understand the problem now. I tried running it myself and got the same result.

What needs to be done is - Exoframe needs a way to store and add header parameters during build execution that'd pass docker registry login and password.

[cmosh]

It's okay. Happens to all of us, I probably also wasn't as clear as I should have been

[maxime1992]

Hi ✋ any news on this?

I've got a private image from gitlab registry, and I've logged into the registry directly from the server but it seems that exoframe cannot pull that image 🤔

I might be missing something but I think it's coming from there

[yamalight]

@maxime1992 haven't had time to work on this at all (it's quite far down the list for me). Would be open to a PR 🤔

[maxime1992]

Damn 😅

I've been refactoring my deploy to avoid having that error:
#199 (comment)

So I've setup a full pipeline on GItlab to build the image first (as gitlab free runners are quite good even for private repos!) but now I can't pull it haha.

haven't had time to work on this at all

No worries :)

Would be open to a PR

Would love to if I had some time for that which I definitely don't =(

[maxime1992]

Hi there, has anyone found a solution to this issue? (or even just a work around)

I'm still stuck 😅

[alexanderadam]

Also there's a migration to Traefik 2.0 in the work. So I guess the code base could lead to merge conflicts anyway.