feat: middleware implementation #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like our server processes are never closing when running puppeteer tests. |
|
Fixed the e2e issues, so tests should pass now |
|
Should shortCircuit just be a response? Like if I wanted to just short circuit the middleware chain, I could just pass a new response to next? |
|
Is there a way to modify a response thats been handled by an internal middleware? |
|
We should just expose |
fix(middleware): return the correct http status code for unsupported content types fix(middleware): handleRequest wasn't last fix(middleware): add return types to functions
dburles
suggested changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.