Update mentoring.md #2347
Closed
Update mentoring.md #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed some word mistakes
github-actions
bot
added
track/python
IsaacG
requested changes
Jun 7, 2024
| @@ -72,16 +72,16 @@ Next, the instructions suggest beginning by creating a function which works for | |||
| The return value of this function will typically be a string, but it can also be a list of strings for later assembly. | |||
| Whether in this function or for the final return, encourage them to use a list and combine the elements using `str.join`. | |||
|
|
|||
| The main challenges are ensuring that the 'hundred' denominator is conditionally included and that the tens and ones columns are joined with a hyphen if they are both present. | |||
| The main challenges are ensuring that the 'hundred' denominator is conditionally included and that the tens and one's columns are joined with a hyphen if they are both present. | |||
There was a problem hiding this comment.
Similar to "tens", this can be read as "the quantity of base one values". In which case, this is not a possessive term and the spelling is correct as-is.
Comment on lines
+83
to
+84
| Encourage the student to use the first function they wrote for each set of three digits rather than duplicating the code. | ||
| Each set of three can be checked individually and conditionally added along with the appropriate denominator or the denominators can be stored in a list and iterated over. |
There was a problem hiding this comment.
I believe the existing notes are grammatically correct as is. I don't see the value in changing this. Changing notes without correcting something adds a lot of churn and overhead.
|
These notes are not consumed by students. They are meant as guidelines to mentors. There is limited value in minor grammatical corrections, especially if the existing notes are correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed some word mistakes