Add Knapsack exercise #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also marks the regular expression string in the generate script as a raw string. This is required to to ensure the escapes are only interpreted as part of the regular expression.
|
@ErikSchierboom this one is ready for review |
Comment on lines
-626
to
-629
| "foregone": [ | ||
| "bank-account", | ||
| "parallel-letter-frequency" | ||
| ], |
There was a problem hiding this comment.
This key is now gone, but it should be moved under the exercises key.
config.json
Outdated
Comment on lines
606
to
609
| "foregone": [ | ||
| "bank-account", | ||
| "parallel-letter-frequency" | ||
| ], |
There was a problem hiding this comment.
Thanks for undoing the remove, but this is still at the root key, instead of within the "exercises" key.
There was a problem hiding this comment.
Apologies, I misunderstood the comment earlier
ErikSchierboom
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the 48in24 exercises.