Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grade-school, bowling: Remove unnecessary mut #346

Merged
merged 2 commits into from
Sep 1, 2017
Merged

grade-school, bowling: Remove unnecessary mut #346

merged 2 commits into from
Sep 1, 2017

Conversation

petertseng
Copy link
Member

Let me know if my understanding of the situation is incorrect and/or I gave an incorrect explanation.

The `iter_mut` yields mutable references; `frame` does not need to be
mutable.

Previously, because of rust-lang/rust#30280
this was not considered a warning.

The fix is in rust-lang/rust#43582
This means on recently nightlies this warning is emitted.
The `or_insert` already returns a mutable reference; `entry` does not
need to be mutable.

Previously, because of rust-lang/rust#30280
this was not considered a warning.

The fix is in rust-lang/rust#43582
This means on recently nightlies this warning is emitted.
Copy link
Contributor

@ijanos ijanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your understanding is correct

@ijanos ijanos merged commit b1f04c0 into exercism:master Sep 1, 2017
@petertseng petertseng deleted the no-mut branch September 1, 2017 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants