Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robot-name: remove redundant tests #1983

Merged
merged 1 commit into from
Aug 16, 2024
Merged

robot-name: remove redundant tests #1983

merged 1 commit into from
Aug 16, 2024

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Aug 16, 2024

[no important files changed]

part of #1824

This is another case where I think it makes sense to actually keep the util function around. It produces a good error message and in combination with the body of the test function, users should have enough information.

As the comment in the diff already states, the removed tests are redundant because the type system prevents such errors anyway.

part of #1824

This is another case where I think it makes sense to actually keep the util
function around. It produces a good error message and in combination with the
body of the test function, users should have enough information.
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@senekor senekor merged commit 9617af2 into main Aug 16, 2024
12 checks passed
@senekor senekor deleted the remo/smwnlnzlyopq branch August 16, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants