[WIP]Implement exercise hangman #1160

khoa102 · 2018-01-10T01:27:25Z

Fixes #745

cmccandless · 2018-01-10T14:16:12Z

khoa102 · 2018-01-10T14:22:57Z

The way I make the exercise is a little bit different from the description. I look at the pull request #905 and it seems from that conversation that I do not need to make it with FRP. I also adapt the tests from the c-sharp tracks.

- Add the text about exception and submition to README

cmccandless

In response to your comment:
difficulty: I would rate this at a medium-ish difficulty (~4-6).
unlocked_by/core: For now, all exercises in this track are unlocked_by: null, core: false
topics: Take a look at the global topics list and determine which are relevant to this exercise. To start, you may look at the topics used in the C# track, but keep in mind that some topics may be more specific to one language than another.

cmccandless · 2018-01-12T15:24:19Z

exercises/hangman/README.md

@@ -0,0 +1,32 @@
+# Need edit


Should be the title of the exercise

cmccandless · 2018-01-12T15:29:48Z

exercises/hangman/hangman_test.py

@@ -0,0 +1,82 @@
+import unittest
+
+from example import Hangman


Import from hangman.

cmccandless · 2018-01-12T15:30:48Z

exercises/hangman/hangman_test.py

+from example import Hangman
+
+
+# Adapt from c-sharp track


Please change to the following:
# Tests adapted from csharp//hangman/HangmanTest.cs

Normally, we would have a comment here citing the version of the canonical data that these tests were based on. In this case, there is no canonical data for this exercise, so this is fine.

@khoa102 Please apply this fix.

…n into implement-hangman-exercise

cmccandless · 2018-01-23T14:18:20Z

config.json

+      "difficulty": 5,
+      "topics":[
+        "events",
+        "reactive_programming"


I would suggest adding strings to this list, as there is inherently some string manipulation involved with this exercise.

…n into implement-hangman-exercise

N-Parsons

The description needs some work, and I think Hangman.status needs to be reworked.

N-Parsons · 2018-01-25T15:22:04Z

exercises/hangman/README.md

@@ -0,0 +1,33 @@
+Hangman


This should be a title: # Hangman

N-Parsons · 2018-01-25T15:26:31Z

exercises/hangman/README.md

+Functional Reactive Programming is a way to write interactive programs. It differs from the usual perspective in that instead of saying "when the button is pressed increment the counter", you write "the value of the counter is the sum of the number of times the button is pressed."
+
+Implement the basic logic behind hangman using functional reactive programming. You'll need to install an FRP library for this, this will be described in the language/track specific files of the exercise.
+


If this exercise isn't about functional reactive programming now, then references to it need to be removed. This needs a track-specific description, which should be put into description.md so that it doesn't get lost.

So, do you have any suggestion on how the description should be? And the file description.md that you mention is in the problem specification right?

N-Parsons · 2018-01-25T15:32:25Z

exercises/hangman/README.md

+For example, if you're submitting `bob.py` for the Bob exercise, the submit command would be something like `exercism submit <path_to_exercism_dir>/python/bob/bob.py`.
+
+For more detailed information about running tests, code style and linting,
+please see the [help page](http://exercism.io/languages/python).


There should be a section at the bottom about submitting incomplete solutions. It's best to generate these using the configlet.

You can install it by running bin/fetch-configlet and then run bin/configlet generate --spec-path <path/to/problem-specifications> --only hangman.

Note that you will have to clone exercism/problem-specifications to generate README files.

N-Parsons · 2018-01-25T15:34:03Z

exercises/hangman/hangman_test.py

+from hangman import Hangman
+
+
+# Tests adapted from csharp//hangman/HangmanTest.cs


Can you add a blank line after this version comment?

N-Parsons · 2018-01-25T16:12:26Z

exercises/hangman/example.py

+class Hangman:
+    def __init__(self, word):
+        self.remainingGuesses = 9
+        self.status = 'busy'


I think "busy" is a little confusing as a status - it makes me think that the class is currently doing something and can't respond. "in progress" might be better?

A better approach to handling status would be to declare some constants at the start of the class (WIN, LOSE, UNFINISHED). The class would then set with self.status = self.WIN and tested with self.assertEqual(game.status, game.WIN). This approach frees up the learner to chose whatever values they find most appropriate/convenient for handling game status.

I also think that we need a test to check that a game that has been lost refuses further interaction. Currently, your example would fail this test, since if I just guess every letter in the alphabet, the status would go to "lose" and then back to "win" once I have guessed all of the letters in the word.

How do want me to stop the game after it is finished (either win or lose)? Should I raise an Exception or Error? or should i just use an if statement and stop it from updating everything in guess()?

@khoa102 Can you clarify what you mean by "stop the game"? Since this is not an interactive program, "stop" loses its meaning.

@cmccandless N-Parson mentions earlier that "a game that has been lost refuses further interaction." And that is what I mean by stopping the game after it's finished (win or lose)

cmccandless · 2018-02-21T19:45:49Z

@khoa102 Are you still interested in completing this?

stale · 2018-05-18T14:14:25Z

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Fixes #745 Solution based on the work of #1160 Config file lint with tool `configlet`, shall I keep all the changes in the config? Ready for review

khoa102 added 2 commits January 10, 2018 08:23

Implement exercise hangman

93d8ddc

Update all files to follow PEP8 standard

fd14531

khoa102 changed the title ~~Implement exercise hangman~~ [WIP]Implement exercise hangman Jan 10, 2018

Merge branch 'master' into implement-hangman-exercise

8166d5a

cmccandless added the enhancement label Jan 10, 2018

update README.md

8fd9f15

- Add the text about exception and submition to README

cmccandless suggested changes Jan 12, 2018

View reviewed changes

khoa102 and others added 4 commits January 21, 2018 16:03

Edit config for exercise Hangman and fix small bugs

8639d32

Merge branch 'implement-hangman-exercise' of github.com:khoa102/pytho…

241cde4

…n into implement-hangman-exercise

Merge branch 'master' into implement-hangman-exercise

17c7fc9

Merge branch 'master' into implement-hangman-exercise

d244773

cmccandless reviewed Jan 23, 2018

View reviewed changes

khoa102 and others added 5 commits January 23, 2018 09:23

Add topic strings for hangman config

09000e9

Merge branch 'implement-hangman-exercise' of github.com:khoa102/pytho…

7e325cf

…n into implement-hangman-exercise

Merge branch 'master' into implement-hangman-exercise

f6c67db

Update adapt comment in test file

3462370

Merge branch 'implement-hangman-exercise' of github.com:khoa102/pytho…

db1eafc

…n into implement-hangman-exercise

cmccandless approved these changes Jan 23, 2018

View reviewed changes

cmccandless requested a review from N-Parsons January 23, 2018 15:47

N-Parsons suggested changes Jan 25, 2018

View reviewed changes

cmccandless mentioned this pull request Feb 15, 2018

Should we forgo any missing exercises #417

Closed

cmccandless added abandoned and removed enhancement labels Apr 27, 2018

stale bot removed the abandoned label Apr 27, 2018

stale bot added the abandoned label May 18, 2018

stale bot closed this May 25, 2018

cmccandless mentioned this pull request Oct 2, 2018

hangman: implement exercise #745

Closed

junming403 mentioned this pull request Feb 26, 2019

Implement exercise hangman #1690

Merged

cmccandless pushed a commit that referenced this pull request Mar 4, 2019

Implement exercise hangman (#1690)

85ff734

Fixes #745 Solution based on the work of #1160 Config file lint with tool `configlet`, shall I keep all the changes in the config? Ready for review

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP]Implement exercise hangman #1160

[WIP]Implement exercise hangman #1160

khoa102 commented Jan 10, 2018 •

edited by cmccandless

Loading

cmccandless commented Jan 10, 2018

khoa102 commented Jan 10, 2018

cmccandless left a comment

cmccandless Jan 12, 2018

cmccandless Jan 12, 2018

cmccandless Jan 12, 2018

cmccandless Jan 23, 2018

cmccandless Jan 23, 2018

N-Parsons left a comment

N-Parsons Jan 25, 2018

N-Parsons Jan 25, 2018

khoa102 Jan 25, 2018

N-Parsons Jan 25, 2018

cmccandless Jan 25, 2018

N-Parsons Jan 25, 2018

N-Parsons Jan 25, 2018

khoa102 Jan 26, 2018 •

edited

Loading

cmccandless Jan 31, 2018

khoa102 Jan 31, 2018

cmccandless commented Feb 21, 2018

stale bot commented May 18, 2018

		Functional Reactive Programming is a way to write interactive programs. It differs from the usual perspective in that instead of saying "when the button is pressed increment the counter", you write "the value of the counter is the sum of the number of times the button is pressed."

		Implement the basic logic behind hangman using functional reactive programming. You'll need to install an FRP library for this, this will be described in the language/track specific files of the exercise.

		from hangman import Hangman


		# Tests adapted from csharp//hangman/HangmanTest.cs

[WIP]Implement exercise hangman #1160

[WIP]Implement exercise hangman #1160

Conversation

khoa102 commented Jan 10, 2018 • edited by cmccandless Loading

cmccandless commented Jan 10, 2018

khoa102 commented Jan 10, 2018

cmccandless left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

N-Parsons left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

khoa102 Jan 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmccandless commented Feb 21, 2018

stale bot commented May 18, 2018

khoa102 commented Jan 10, 2018 •

edited by cmccandless

Loading

khoa102 Jan 26, 2018 •

edited

Loading