-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dnd character #169
Dnd character #169
Conversation
Test suite shouldn't show how to calculate hitpoints. That was a lack of my imagination at the time. Instead we should check if it falls in a range between 6 and 14. |
Otherwise, it looks good to me. |
Looking at this closer now that I'm off work, but I'd suggest adding a comment that indicates the |
Comment looks good. I was unsure about the indentation since re-indenting with CPO resulted in this:
However, it looks like it's indenting the method line relative to
becomes
There's no difference in behavior when |
I think it's fine as-is: plenty of other tracks do exactly this.
I used similar indenting to |
Fixes #168