Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PureScript 0.15.15 and latest package set, clean up exercises and scripts #312

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

FranklinChen
Copy link
Contributor

@FranklinChen FranklinChen commented Feb 3, 2025

  • package.json (ncu -u)
  • packages.dhall (npx spago upgrade-set)
  • template/spago.dhall (replace deprecated math with numbers; add exceptions)
  • exercises/*/{spago,packages}.dhall (bin/update-exercises.sh)
  • update .gitignore also

Use

for i in exercises/*/*; do (cd $i; spago test); done >& /tmp/build.log

to verify that everything builds and runs.

- package.json (ncu -u)
- packages.dhall (npx spago upgrade-set)
- template/spago.dhall (replace deprecated math with numbers; add exceptions)
- exercises/*/{spago,packages}.dhall (bin/update-exercises.sh)
- update .gitignore also

Use

for i in exercises/*/*; do (cd $i; spago test); done >& /tmp/build.log

to verify that everything builds and runs.
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

Copy link
Contributor

github-actions bot commented Feb 3, 2025

This is an unmaintained repository.

Cross-track maintainers - feel free to merge.

@github-actions github-actions bot closed this Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@SleeplessByte
Copy link
Member

@FranklinChen
Copy link
Contributor Author

I updated the versions in the GitHub Actions but am not sure how to test this.

@SleeplessByte
Copy link
Member

@FranklinChen by me pushing the button 😅😁🎢

@SleeplessByte
Copy link
Member

at examples/src/CryptoSquare.purs:19:1 - 19:19 (line 19, column 1 - line 19, column 19)
Module Math was not found.

https://github.com/exercism/purescript/actions/runs/13120906267/job/36688327093?pr=312

…s to use Data.Number instead of Math for sqrt. Use scripts/ci to verify all tests for everything pass.
@FranklinChen
Copy link
Contributor Author

Sorry! Fixed it by testing using scripts/ci.

@SleeplessByte SleeplessByte merged commit 63b8fd6 into exercism:main Feb 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants