-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to PureScript 0.15.15 and latest package set, clean up exercises and scripts #312
Conversation
- package.json (ncu -u) - packages.dhall (npx spago upgrade-set) - template/spago.dhall (replace deprecated math with numbers; add exceptions) - exercises/*/{spago,packages}.dhall (bin/update-exercises.sh) - update .gitignore also Use for i in exercises/*/*; do (cd $i; spago test); done >& /tmp/build.log to verify that everything builds and runs.
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
Hello 👋 Thanks for your PR. This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed. If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track. Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum. (cc @exercism/cross-track-maintainers) |
This is an unmaintained repository. Cross-track maintainers - feel free to merge. |
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
Please see https://github.com/exercism/purescript/actions/runs/13117777989/job/36596296008?pr=312 for the CI failure @FranklinChen |
I updated the versions in the GitHub Actions but am not sure how to test this. |
@FranklinChen by me pushing the button 😅😁🎢 |
https://github.com/exercism/purescript/actions/runs/13120906267/job/36688327093?pr=312 |
…s to use Data.Number instead of Math for sqrt. Use scripts/ci to verify all tests for everything pass.
Sorry! Fixed it by testing using |
ncu -u
)npx spago upgrade-set
)bin/update-exercises.sh
)Use
to verify that everything builds and runs.