dominoes: improve description readability #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Insti
reviewed
Oct 26, 2017
exercises/dominoes/description.md
Outdated
| @@ -5,9 +5,9 @@ correct domino chain (the dots on one half of a stone match the dots on the | |||
| neighbouring half of an adjacent stone) and that dots on the halfs of the stones | |||
| which don't have a neighbour (the first and last stone) match each other. | |||
|
|
|||
| For example given the stones `21`, `23` and `13` you should compute something | |||
| like `12 23 31` or `32 21 13` or `13 32 21` etc, where the first and last numbers are the same. | |||
| For example given the stones `(2, 1)`, `(2, 3)` and `(1, 3)` you should compute something | |||
There was a problem hiding this comment.
Would square brackets be more appropriate here?
And is "comma space" the best separator?
Possible alternatives:
[1, 1] [2,2] [3|3] [4:4]
|
Moving away from 2 digit numbers is an improvement 👍 |
|
@Insti I like [3|3]. "Tuple" format was chosen because many languages can implement this will naturally using tuples, so there representation is quite clear. |
That makes sense but we don't necessarily want the description to be prompting specific implementation details. |
Insti
approved these changes
Oct 26, 2017
petertseng
approved these changes
Oct 27, 2017
cmccandless
added a commit
to cmccandless/python
that referenced
this pull request
Oct 27, 2017
N-Parsons
pushed a commit
to exercism/python
that referenced
this pull request
Nov 5, 2017
* add dominoes/README.md * Add test cases and example solution for dominoes * add dominoes to config.json * dominoes: add check for name == "__main__" * dominoes: update canonical data version and formatting fixes in README * dominoes: update README to latest description RE: exercism/problem-specifications#972
smalley
pushed a commit
to smalley/python
that referenced
this pull request
Nov 12, 2017
* add dominoes/README.md * Add test cases and example solution for dominoes * add dominoes to config.json * dominoes: add check for name == "__main__" * dominoes: update canonical data version and formatting fixes in README * dominoes: update README to latest description RE: exercism/problem-specifications#972
smalley
pushed a commit
to smalley/python
that referenced
this pull request
Nov 12, 2017
* add dominoes/README.md * Add test cases and example solution for dominoes * add dominoes to config.json * dominoes: add check for name == "__main__" * dominoes: update canonical data version and formatting fixes in README * dominoes: update README to latest description RE: exercism/problem-specifications#972
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework domino representation to avoid confusion with 2-digit numbers
23vs. a domino(2, 3).