Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: remove order dependency from anagram test #873

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

neenjaw
Copy link
Collaborator

@neenjaw neenjaw commented Jan 16, 2025

It was raised in the forum that the canonical problem specifications have several flaws:

  • vague language
  • are not congruent with the existing tests in many tracks

This change list removes the dependency on the order of the returned words that have been validated as candidates.

@neenjaw neenjaw self-assigned this Jan 16, 2025
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@neenjaw neenjaw added x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation labels Jan 16, 2025
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for stepping in!

exercises/practice/anagram/AnagramTest.php Outdated Show resolved Hide resolved
exercises/practice/anagram/AnagramTest.php Outdated Show resolved Hide resolved
neenjaw and others added 2 commits January 19, 2025 12:51
Co-authored-by: mk-mxp <55182845+mk-mxp@users.noreply.github.com>
Co-authored-by: mk-mxp <55182845+mk-mxp@users.noreply.github.com>
@neenjaw
Copy link
Collaborator Author

neenjaw commented Jan 19, 2025

@mk-mxp your suggestions have been applie

@neenjaw neenjaw requested a review from mk-mxp January 19, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/tiny Tiny amount of reputation x:size/tiny Tiny amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants