Handle invalid UTF-8 and "DEL" ASCII code #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In user output, e.g. for debugging, and in test failure messages there may be invalid UTF-8 or an ASCII DEL character. Invalid UTF-8 stopped PHP from producing JSON completely. This was found while working on Rotational Cipher, where ASCII characters are rotated and might result in invalid UTF-8. ASCII DEL character was also produced during that exercise and resulted in wrongly displayed output vs. JSON. PHPUnit detects ASCII control chars and turns output to "binary string" - but not for invisible DEL character (0x7F), which consumes the following character on screen.
homersimpsons
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139
In user output, e.g. for debugging, and in test failure messages there may be invalid UTF-8 or an ASCII DEL character.
Invalid UTF-8 stopped PHP from producing JSON completely. This was found while working on Rotational Cipher, where ASCII characters are rotated and might result in invalid UTF-8.
ASCII DEL character was also produced during that exercise and resulted in wrongly displayed output vs. JSON. PHPUnit detects ASCII control chars and turns output to "binary string" - but not for invisible DEL character (0x7F), which consumes the following character on screen.