Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acronym test template #536

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Fix acronym test template #536

merged 1 commit into from
Feb 19, 2025

Conversation

kahgoh
Copy link
Member

@kahgoh kahgoh commented Feb 19, 2025

Previously, the test template had an extra level of {{#cases}} which was causing the generator to duplicate the test cases.

This change only removes duplicate test cases from the acronym test cases, so we should NOT need to rerun tests.

[no important files changed]


Fixes an issue reported at https://forum.exercism.org/t/acronym-seems-to-have-duplicated-tests/15840

Previously, the test template had an extra level of {{#cases}} which
was causing the generator to duplicate the test cases.

This change only removes duplicate test cases from the acronym test
cases, so we should NOT need to rerun tests.

[no important files changed]
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@kahgoh
Copy link
Member Author

kahgoh commented Feb 19, 2025

+cc @georgyo

@georgyo
Copy link
Member

georgyo commented Feb 19, 2025

Good eye!

@kahgoh kahgoh merged commit efcf98e into exercism:main Feb 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants