Skip to content

Commit

Permalink
Adding analyzer feedback for wizards-and-warriors-2 concept exerc…
Browse files Browse the repository at this point in the history
…ise (#2742)

* Adding analyzer feedback for wizards-and-warriors-2 concept exercise

* Adding removed header

* Update exercises/concept/wizards-and-warriors-2/.meta/design.md

Co-authored-by: Sander Ploegsma <sanderploegsma@gmail.com>

* Update exercises/concept/wizards-and-warriors-2/.meta/design.md

Co-authored-by: Sander Ploegsma <sanderploegsma@gmail.com>

---------

Co-authored-by: Sander Ploegsma <sanderploegsma@gmail.com>
  • Loading branch information
manumafe98 and sanderploegsma authored Feb 29, 2024
1 parent 3c47803 commit 82c467a
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions exercises/concept/wizards-and-warriors-2/.meta/design.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,14 @@ This exercise does not require any specific representation logic to be added to

## Analyzer

This exercise does not require any specific analyzer logic to be added to the [analyzer][analyzer-java].
This exercise could benefit from the following rules in the [analyzer]:

- `actionable`: If the student does not reuse the methods `describe(Character)`, `describe(Destination)` or `describe(TravelMethod)` to solve the `describe(Character, Destination, TravelMethod)` method, instruct them to do so.
- `actionable`: If the student does not reuse the method `describe(Character)`, `describe(Destination)`, `describe(TravelMethod)` or `describe(Character, Destination, TravelMethod)` to solve the `describe(Character, Destination)` method, instruct them to do so.
- `informative`: If the solution uses `String.format` in any of the `describe` methods, inform the student that this cause a small performance penalty compared to string concatenation.

If the solution does not receive any of the above feedback, it must be exemplar.
Leave a `celebratory` comment to celebrate the success!

[representer-java]: https://github.com/exercism/java-representer
[analyzer-java]: https://github.com/exercism/java-analyzer
[analyzer]: https://github.com/exercism/java-analyzer

0 comments on commit 82c467a

Please sign in to comment.