Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Elixir 1.18 #1540

Merged
merged 5 commits into from
Jan 6, 2025
Merged

Update to Elixir 1.18 #1540

merged 5 commits into from
Jan 6, 2025

Conversation

jiegillet
Copy link
Contributor

Pretty straightforward, only one kind of warning.
I checked here that we could drop 1.13.

Also closes #1528, except for the elixir school link, but who knows when that will be updated.

Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Concept exercise changed

    • 🌲 Do prerequisites and practices in config.json need to be updated?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?
  • Concept changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <concept>/.meta/config.json (see docs)?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?

Automated comment created by PR Commenter 🤖.

@jiegillet jiegillet marked this pull request as ready for review December 21, 2024 04:11
@angelikatyborska
Copy link
Member

I think we can merge this one without waiting for the tooling repos, so at least locally you can use 1.18?

@jiegillet
Copy link
Contributor Author

Sorry, new year food (and maybe the latest Zelda game? 👼) occupied my mind and I didn't check my emails at all last week.
I tweaked the versions while I was at it and I merged it.

@jiegillet jiegillet merged commit ad095ee into main Jan 6, 2025
8 of 9 checks passed
@jiegillet jiegillet deleted the jie-elixir-1.18 branch January 6, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate unless in Elixir 1.18
2 participants