Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key features #613

Merged
merged 2 commits into from
May 4, 2021
Merged

Add key features #613

merged 2 commits into from
May 4, 2021

Conversation

wolf99
Copy link
Contributor

@wolf99 wolf99 commented Feb 1, 2021

Fixes #604

Draft until the icons are available

@wolf99 wolf99 force-pushed the v3-key-features branch 3 times, most recently from 37c1e7e to 5e6d85b Compare February 7, 2021 18:17
@wolf99 wolf99 force-pushed the v3-key-features branch from 8d13a72 to 3a34e76 Compare March 6, 2021 18:39
@wolf99 wolf99 force-pushed the v3-key-features branch from 3a34e76 to 2ac134d Compare April 8, 2021 17:34
@wolf99
Copy link
Contributor Author

wolf99 commented Apr 8, 2021

Looks like tracks are merging these with the icons either empty (i.e. "icon": "") or set to "feature-{feature-title}" (e.g. `"icon": "feature-cross-platform").

I have left as the former so that it is evident that something further needs doing. But am open to change to the latter if preferred. Either way, this is ready for review.

@wolf99 wolf99 marked this pull request as ready for review April 8, 2021 17:40
@wolf99 wolf99 requested a review from a team April 8, 2021 17:41
@ryanplusplus ryanplusplus merged commit 5654d12 into main May 4, 2021
@ryanplusplus ryanplusplus deleted the v3-key-features branch May 4, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] Add key features
2 participants