Add feature flag for lazy loading #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
force-pushed
the
conditional-load-flag
branch
from
2ecce55 to
1c6acbc
Compare
choldgraf
force-pushed
the
conditional-load-flag
branch
from
1c6acbc to
19cc616
Compare
|
tracking reverting the default here: #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akhmerov rightly pointed out that our current lazy loading behavior will break some downstream projects that use this as part of their builds, but don't use the directive in this extension. We're tracking that in #34
This PR puts this behavior behind a feature flag and changes the default so that it now loads by default on every page. We can re-visit changing the default behavior once we are sure that it won't be too disruptive.