Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim paragraph margins at the bottom of tab panels #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benjaoming
Copy link

This change affects all themes, however the behavior may also be visually problematic in several themes. I only just noticed it in sphinx-rtd-theme.

Themes that aren't affected probably also aren't affected by the margin change, since in this case they probably don't put margins under p elements.

As I understand sphinx-tabs-panel p:last-child, it will trigger if that particular <p> element is the last of all child elements in the tabs panel. So that should work as intended.

Before:
image

After:

image

@welcome
Copy link

welcome bot commented Jan 26, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@benjaoming
Copy link
Author

Just noticed #143 - the implementation there wouldn't work for panels with several paragraphs.

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 97.27% // Head: 97.27% // No change to project coverage 👍

Coverage data is based on head (1feb1f8) compared to base (9431223).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files           2        2           
  Lines         220      220           
=======================================
  Hits          214      214           
  Misses          6        6           
Flag Coverage Δ
pytests 97.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant