Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes https://github.com/executablebooks/jupyter-book/issues/1414 #94

Merged
merged 5 commits into from
Oct 29, 2023
Merged

fixes https://github.com/executablebooks/jupyter-book/issues/1414 #94

merged 5 commits into from
Oct 29, 2023

Conversation

jdsalaro
Copy link
Contributor

@jdsalaro jdsalaro commented Jul 4, 2023

Summary

Should address jupyter-book/jupyter-book#1414 and #93 , also adds CONTRIBUTING.md mirroring that of the jupyter-book project.

@welcome
Copy link

welcome bot commented Jul 4, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@jdsalaro
Copy link
Contributor Author

jdsalaro commented Jul 4, 2023

cc @mmcky @chrisjsewell , this is my suggested fix to #93 and jupyter-book/jupyter-book#1414 , let me know if there's anything else I can do.

jdsalaro and others added 2 commits July 4, 2023 11:16
@jdsalaro
(use "git restore --staged <file>..." to unstage)
794cecb 
modified:   .pre-commit-config.yaml
modified:   sphinx_external_toc/events.py
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d3f12d6 
for more information, see https://pre-commit.ci
@jdsalaro
Copy link
Contributor Author

jdsalaro commented Jul 4, 2023

Pre-commit checks failed before but are passing now. I don't know what the Codecov CI errors are about, though.

image

@jdsalaro
Copy link
Contributor Author

jdsalaro commented Sep 7, 2023

@fwkoch @choldgraf apologies for pinging you directly here, but code coverage uploads in this projects CI seem like have been broken for months:

image

Also, is there a chance someone from the Executable Books team could have a look at this simple pull request as a suggested fix to #93 ? 🙏🏼

Happy to help with maintenance in any capacity as well since I use EB tools for quite a few of my projects 👍🏼

@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
sphinx_external_toc/parsing.py 92.13% <ø> (ø)
sphinx_external_toc/tools.py 90.18% <ø> (ø)
sphinx_external_toc/events.py 89.53% <60.00%> (-0.95%) ⬇️

📢 Thoughts on this report? Let us know!.

@agoose77 agoose77 merged commit 8fbb76c into executablebooks:main Oct 29, 2023
4 of 6 checks passed
@welcome
Copy link

welcome bot commented Oct 29, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@agoose77 agoose77 mentioned this pull request Oct 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdsalaro @agoose77