👌 IMPROVE: Add link-alt
to fix card link accessibility
#89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
link-alt
option tocard
(andgrid-item-card
) directives,in order to assign a discernable name to the link (for screen readers).
As noted in #78, it may be ideal to add
aria-label/
aria-hiddento the actual link
HTML element. However, this would entail having to override aspects of the sphinx HTML builder. Instead, we include the link alt text, but add a
sd-hide-link-textCSS class, to set
font-size: 0`, to hide the text.This solution was taken from https://stackoverflow.com/questions/471510/hide-text-using-css, and seemed to be the simplest solution.
fixes #78