-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Update Materials Design Icons to v4.0.0-46-gc9e5528 #69
Conversation
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 88.98% 88.98%
=======================================
Files 11 11
Lines 917 917
=======================================
Hits 816 816
Misses 101 101
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
thanks, is there some kind of versioning for these icons though? |
Unfortunately, no. The Google team isn't very forthcoming about the material icons repo. They recently stopped accepting new icons from outside their "inner circle". You may already be aware of the third party MDI node.js pkg(s) because they've given up maintaining npm releases on their end also. The last release (v4.0.0 long ago) was a huge re-organization of the repo that isn't very Windows friendly. This is why I use a shortened sha in my repo that compiles these JSONs once a month. |
If you want I could add the SHA somewhere. On my repo's CI, I capture the These assets submitted here are compiled from My repo's CI is scheduled to run once a month, and I have to check in on its progress (every other month) to keep the CI workflow enabled. |
for more information, see https://pre-commit.ci
…sign into update-MD-icons
Huge update to the material icons repo today. I'll update this PR in accordance (hopefully tomorrow). I'll also add a versioned identifier (probably using SHA in a separate file). |
OK. I've updated the JSONs using the latest commit from google's MDI repo. I also added a material-icons_VERSION.txt file that includes:
|
thanks for this @2bndy5, sorry I was still differing a little because of the large diff. data = {}
base = Path("sphinx_design/compiled")
for path in base.glob("material_*.json"):
mtype = path.name[9:-5]
for name in json.loads(path.read_text()):
data.setdefault(name, [])
data[name].append(mtype)
base.joinpath("names_material.json").write_text(json.dumps(data, indent=2, sort_keys=True)) As you can see (by the right bar), there are only additions, which in my book means no breaking changes 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers!
Again, I wish the Google team was a lot more explanatory about their changes to the icons repo. The last big change was from a PR labeled "update icons" with no description. The merge commit was so large that github couldn't display the diff... |
This adds 421 icons; some are fresh icons, and some are just different sizes. Threre might be some name changes, but it should be current with what is shown on the https://fonts.google.com/icons (as referenced by this ext's docs).