Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add a bootstrap function for all changelog entries #64

Merged
merged 8 commits into from
Apr 9, 2022
Merged

[ENH] Add a bootstrap function for all changelog entries #64

merged 8 commits into from
Apr 9, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Dec 11, 2021 •
edited
Loading

Fixes #57

e.g. github-activity executablebooks/github-activity --all

@blink1073 blink1073 added the enhancement New feature or request label Dec 11, 2021
@blink1073 blink1073 marked this pull request as draft December 11, 2021 02:57
@blink1073 blink1073 changed the title Add a bootstrap function for all changelog entries [ENH] Add a bootstrap function for all changelog entries Dec 12, 2021
@blink1073 blink1073 marked this pull request as ready for review December 12, 2021 01:18
@blink1073 blink1073 requested a review from choldgraf December 17, 2021 11:40
@blink1073
Copy link
Contributor Author

cc @choldgraf @consideRatio

choldgraf
choldgraf approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick comments, but in general this looks good to me. I don't have time to do a really deep dive on the code but it seems good!

github_activity/github_activity.py
with TemporaryDirectory() as td:

subprocess.run(
shlex.split(f"git clone https://github.com/{target} repo"), cwd=td
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How have I never heard of shlex.split before? It looks so useful!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah totally. Thanks for the review!

github_activity/cli.py Show resolved Hide resolved
@blink1073 blink1073 merged commit c38e325 into executablebooks:master Apr 9, 2022
@blink1073 blink1073 deleted the all-changelog branch April 9, 2022 22:13
@choldgraf
Copy link
Member

Woot! And sorry for the slow turnaround on this one

@jtpio jtpio mentioned this pull request May 19, 2022
Merged
@jtpio
Copy link

jtpio commented Feb 13, 2023 •
edited
Loading

Any chance there could be a new release of github-activity that would include this change?

I tried using the --all flag to bootstrap the changelog for an existing project but it doesn't seem to be available yet.

Thanks!

@blink1073
Copy link
Contributor Author

https://github.com/executablebooks/github-activity/releases/tag/v0.3.0

@jtpio
Copy link

jtpio commented Feb 13, 2023

That was fast, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backfill / bootstrap an initial changelog
3 participants
@blink1073 @choldgraf @jtpio