Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auth for all usages of requests #60

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

blink1073
Copy link
Contributor

Fixes #46

@welcome
Copy link

welcome bot commented Nov 24, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

Copy link
Collaborator

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I loooooove that the error comment includes "you don’t need to set any scopes on the token you create.", it is such a relief to have that explicit!

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - agree w/ @consideRatio that the error message is great as well :-)

My only comment is that @consideRatio should feel free to merge-away if he thinks it looks good!

@choldgraf choldgraf merged commit bb50df5 into executablebooks:master Nov 24, 2021
@welcome
Copy link

welcome bot commented Nov 24, 2021

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@blink1073 blink1073 added the enhancement New feature or request label Dec 1, 2021
@blink1073 blink1073 added this to the 0.2 milestone Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass auth token to Datetime from git ref function
3 participants