Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 remove redundant mypy config #866

Merged

Conversation

danieleades
Copy link
Contributor

no_implicit_optional is the default value in mypy these days, so this config is redundant

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (e74769c) to head (45aaa42).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #866   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files          24       24           
  Lines        3372     3372           
=======================================
  Hits         3037     3037           
  Misses        335      335           
Flag Coverage Δ
pytests 90.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell changed the title remove redundant mypy config 🔧 remove redundant mypy config Mar 26, 2024
@chrisjsewell chrisjsewell merged commit c3fa3db into executablebooks:master Mar 26, 2024
20 checks passed
Copy link

welcome bot commented Mar 26, 2024

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@danieleades danieleades deleted the mypy-implicit-optional-default branch March 26, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants