Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web-test-runner concurrency to 1 #226

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

pkayokay
Copy link
Contributor

@pkayokay pkayokay commented Mar 17, 2024

This may help reduce the failures we're seeing in CI and local. I actually got pretty consistent results of passing tests locally by reducing the concurrency option to 1.

Similar issue found here

@excid3 excid3 merged commit f2f8646 into excid3:main Mar 17, 2024
1 check passed
@excid3
Copy link
Owner

excid3 commented Mar 17, 2024

Excellent! Thanks!

@pkayokay
Copy link
Contributor Author

@excid3 I found out we could alternatively update the timeout as well in the config. If the solution here is inconsistent we can also up the timeout time. Adding this as a comment here in case we need it in the future.

{
  concurrency: 1,
  files: "test/**/*_test.js",
  nodeResolve: true,
  filterBrowserLogs,
  mimeTypes: {},
  plugins: [],
  testFramework: {
    config: {
      timeout: '10000',
    },
  },
}

@excid3
Copy link
Owner

excid3 commented Mar 22, 2024

Cool, it seems pretty stable now with concurrency of 1 and we only have a few tests so it's fast enough.

I don't really understand the flakiness having more concurrency though. 🤷‍♂️

@excid3
Copy link
Owner

excid3 commented Mar 22, 2024

One thing I did notice yesterday, one test was consistently failing because we initialize the fixture before Stimulus in the test. Swapping the order to initialize the Stimulus component and then load the fixture made it reliable. Maybe that was the source of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants