-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExceptionlessTarget - ApiKey and ServerUrl and Message and UserIdentity with Layout support #299
Conversation
…entity and ReferenceId with Layout support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment. I don't think we can use reference id's like this because they will be discarded events server side as each event needs to be unique, can you please confirm.
@ejsmith may want to consider bringing correlation id in as it may help track down issues in otel. I'm not sure how well our event references we store in extended data for this scenario would help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, had a question about target changes
Thanks for the PR!!!!!! |
Resolves #297 and resolves #296
${aspnet-user-identity} comes from NLog.Web.AspNetCore-nuget-package . See also: https://nlog-project.org/config/?tab=layout-renderers