Add ILoggingBuilder extension methods #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wu-yafeng
commented
Mar 10, 2020
wu-yafeng
commented
- Add ILoggingBuilder extension methods
- Markup ILoggerFactory extension methods obsolute
- Add sample codes in SampleAspNetCore
- Add ILoggingBuilder extension methods - Markup ILoggerFactory extension methods obsolute - Add sample codes in SampleAspNetCore
|
|
niemyjski
requested changes
Mar 11, 2020
| @@ -15,7 +15,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Label="Package References"> | |||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="2.2.0" /> | |||
| <PackageReference Include="Microsoft.Extensions.Logging" Version="3.1.2" /> | |||
There was a problem hiding this comment.
Is there any reason we can't keep using the abstractions lib and target 2.2?
There was a problem hiding this comment.
In order to use ILoggingBuilder,I have to use Microsoft.Extensions.Logging instead of Microsoft.Extensions.Logging.Abstractions.
It seems reasonable to use 2.2 not 3.1.
src/Platforms/Exceptionless.Extensions.Logging/ExceptionlessLoggerExtensions.cs
Outdated
Show resolved
Hide resolved
src/Platforms/Exceptionless.Extensions.Logging/ExceptionlessLoggerExtensions.cs
Outdated
Show resolved
Hide resolved
- Use 2.2 logging component - fix some typo - remove regions
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.