#128 migrate project to pyrpoject toml based package setup #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaklakariada
requested changes
May 31, 2022
tkilias
requested changes
Jun 1, 2022
Conda forge is not maintained anymore.
For now the version and iformation will be updated using a git hook and nox target. When the project is upgraded to 3.8 we should replace this mechanism by the use of importlib.metadata. see also: * #145 (comment) * python-poetry/poetry#2366 (comment) * #135 (comment)
kaklakariada
requested changes
Jun 1, 2022
tkilias
requested changes
Jun 1, 2022
This was
linked to
issues
Jul 7, 2022
tkilias
requested changes
Jul 12, 2022
tkilias
requested changes
Jul 13, 2022
tkilias
requested changes
Jul 13, 2022
Either use environment variables for credentials if available, otherwise to fallback to interactivly asking for the credentials.
tkilias
previously approved these changes
Jul 13, 2022
Nicoretti
requested review from
kaklakariada
and removed request for
kaklakariada
Nicoretti
force-pushed
the
feature/#128-migrate-project-to-pyrpoject-toml-based-package-setup
branch
from
1e5ba0c to
95d77a9
Compare
tkilias
approved these changes
Jul 14, 2022
kaklakariada
approved these changes
Jul 14, 2022
Nicoretti
deleted the
feature/#128-migrate-project-to-pyrpoject-toml-based-package-setup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #128