Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Various SQLA compliance tests are failing for the websocket based dialect #342

Closed
Nicoretti opened this issue May 22, 2023 · 0 comments · Fixed by #357
Closed

🐞 Various SQLA compliance tests are failing for the websocket based dialect #342

Nicoretti opened this issue May 22, 2023 · 0 comments · Fixed by #357
Assignees
@Nicoretti @kaklakariada
Labels
bug Unwanted / harmful behavior

Comments

@Nicoretti
Copy link
Member

Nicoretti commented May 22, 2023 •
edited
Loading

Summary

Various SQLA compliance tests are failing for the websocket based dialect.

Reproducing the Issue

Reproducible: always

  1. Remove the @ISSUE342 marker from the tests in test/sqlalchemy/test_suite.py

  2. Run the SQLA compliance test suit with the websocket based dialect as target
    pytest --log-debug=DEBUG --dropfirst --db exasol-websocket test/integration/sqlalchemy

  3. Have a look at the following tests

  • test/integration/sqlalchemy/test_suite.py::InsertBehaviorTest_exasol+exasol_driver_websocket_dbapi2::test_empty_insert_multiple_teardown
  • test/integration/sqlalchemy/test_suite.py::InsertBehaviorTest_exasol+exasol_driver_websocket_dbapi2::test_insert_from_select - sqlalchemy.exc.DBAPIError: (exasol.driver.websocket._errors.Error)
  • test/integration/sqlalchemy/test_suite.py::NumericTest_exasol+exasol_driver_websocket_dbapi2::test_float_coerce_round_trip - AssertionError: '15.7563' != 15.7563
  • test/integration/sqlalchemy/test_suite.py::NumericTest_exasol+exasol_driver_websocket_dbapi2::test_numeric_as_float - AssertionError: {'15.7563'} != {15.7563}
  • test/integration/sqlalchemy/test_suite.py::NumericTest_exasol+exasol_driver_websocket_dbapi2::test_render_literal_numeric_asfloat - AssertionError: assert '15.7563' in [15.7563]

Expected Behavior

All tests are executed successfully.

Actual Behavior

Various tests fail, namely:

  • test/integration/sqlalchemy/test_suite.py::InsertBehaviorTest_exasol+exasol_driver_websocket_dbapi2::test_empty_insert_multiple_teardown
  • test/integration/sqlalchemy/test_suite.py::InsertBehaviorTest_exasol+exasol_driver_websocket_dbapi2::test_insert_from_select - sqlalchemy.exc.DBAPIError: (exasol.driver.websocket._errors.Error)
  • test/integration/sqlalchemy/test_suite.py::NumericTest_exasol+exasol_driver_websocket_dbapi2::test_float_coerce_round_trip - AssertionError: '15.7563' != 15.7563
  • test/integration/sqlalchemy/test_suite.py::NumericTest_exasol+exasol_driver_websocket_dbapi2::test_numeric_as_float - AssertionError: {'15.7563'} != {15.7563}
  • test/integration/sqlalchemy/test_suite.py::NumericTest_exasol+exasol_driver_websocket_dbapi2::test_render_literal_numeric_asfloat - AssertionError: assert '15.7563' in [15.7563]

Related Issues (optional)
@Nicoretti Nicoretti added the bug Unwanted / harmful behavior label May 22, 2023
@Nicoretti Nicoretti mentioned this issue May 22, 2023
Closed
@Nicoretti Nicoretti changed the title 🐞Various SQLA compliance tests are failing for the websocket based dialect 🐞 Various SQLA compliance tests are failing for the websocket based dialect May 22, 2023
@Nicoretti Nicoretti mentioned this issue May 22, 2023
Closed
Nicoretti added a commit that referenced this issue May 23, 2023
@Nicoretti
Disable remaing failing SQLA compliance tests
89388e8 
See also:

* #341
* #342
Nicoretti added a commit that referenced this issue May 24, 2023
@Nicoretti
Add support for pyexasol part 2/2 (#320)
a22bd4a 
* Add hooks for websocket based exasol dialect
* Add support for enabling and disabling certificate validation
* Add hooks for type conversions between pyexasol and dbapi2 cursor
* Add websocket dialect/connector to ci/cd matrix
* Update dependencies
* Update README.md
* Rework dbapi2 types
* Restructure the dbapi2 module of the websocket driver
* Disable remaining failing SQLA compliance tests
   - #341
   - #342

---
Co-authored-by: Christoph Pirkl <christoph.pirkl@exasol.com>
Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
Co-authored-by: Torsten Kilias <tkilias@users.noreply.github.com>
@Nicoretti Nicoretti self-assigned this Jul 13, 2023
@Nicoretti Nicoretti mentioned this issue Jul 14, 2023
Merged
Nicoretti added a commit that referenced this issue Jul 14, 2023
@Nicoretti
Reenable test for issue #342
d9038dc
@kaklakariada kaklakariada self-assigned this Jul 14, 2023
Nicoretti added a commit that referenced this issue Jul 17, 2023
@Nicoretti
Fix failing sqla compliance tests for ws dialect (#357)
04b31c3 
* Re enable test for issue #342
* Mark unsupported feature as xfail
* Convert Decimal type to float if decimal isn't enforced
* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nicoretti Nicoretti

@kaklakariada kaklakariada

Labels
bug Unwanted / harmful behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug/#342 failing sqla compliance tests for ws dialect exasol/sqlalchemy-exasol
2 participants
@Nicoretti @kaklakariada