Skip to content

Commit

Permalink
Removing upload of db logs to Github artifacts to prevent potential f…
Browse files Browse the repository at this point in the history
…uture leakage of secrets, because Github doesn't hide secrets in uploaded files.
  • Loading branch information
tkilias committed Nov 30, 2023
1 parent 9ba64f2 commit 2f6adfa
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,4 @@ jobs:
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_ROLE: ${{ secrets.AWS_ROLE }}
AWS_DEFAULT_REGION: "eu-central-1"
run: poetry run pytest tests/ci_tests -s
- name: Archive DockerDB logs
if: success() || failure()
run: docker cp db_container_test:/exa/logs docker_db_logs
- name: Archive DockerDB logs
if: success() || failure()
uses: actions/upload-artifact@v1
with:
name: docker_db_logs
path: docker_db_logs

run: poetry run pytest tests/ci_tests -s

0 comments on commit 2f6adfa

Please sign in to comment.