#307 Made each notebook test a separate job #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsimb
had a problem deploying
to
approve-test-execution
GitHub Actions
Failure
ahsimb
had a problem deploying
to
approve-test-execution
GitHub Actions
Failure
ahsimb
had a problem deploying
to
approve-test-execution
GitHub Actions
Failure
ahsimb
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
ahsimb
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
ahsimb
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
ahsimb
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
ckunki
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Could you please try to use a matrix test?
This would avoid a lot of code duplication.
There was a problem hiding this comment.
There was a problem hiding this comment.
Please update changes documentation, incl. a reference to the ticket requesting these changes.
ahsimb
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
ahsimb
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
ahsimb
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
ckunki
approved these changes
Jul 30, 2024
Comment on lines
+14
to
+17
| - { name: "sklearn notebook", test_file: "nbtest_sklearn.py" } | ||
| - { name: "ibis notebook", test_file: "nbtest_ibis.py" } | ||
| - { name: "SLC notebook", test_file: "nbtest_script_languages_container.py" } | ||
| - { name: "short notebook tests", test_file: "\"nbtest_environment_test.py nbtest_itde.py\""} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #307