#307 Made each notebook test a separate job

exasol · Jul 26, 2024 · 30c0706 · 30c0706
1 parent e850ba4
commit 30c0706
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/.github/workflows/notebook_tests.yaml b/.github/workflows/notebook_tests.yaml
@@ -18,12 +18,12 @@ jobs:
 
       - name: Run notebook tests
         run: >
-         poetry run pytest
-          --capture=no
-          --override-ini=log_cli=true
-          --override-ini=log_cli_level=INFO
-          --nb_test_file=nbtest_sklearn.py
-          test/notebook_test_runner/test_notebooks_in_dss_docker_image.py
+          poetry run pytest
+            --capture=no
+            --override-ini=log_cli=true
+            --override-ini=log_cli_level=INFO
+            --nb-test-file=nbtest_sklearn.py
+            test/notebook_test_runner/test_notebooks_in_dss_docker_image.py
         env:
           SAAS_HOST: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_HOST }}
           SAAS_ACCOUNT_ID: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_ACCOUNT_ID }}
@@ -43,12 +43,12 @@ jobs:
 
       - name: Run notebook tests
         run: >
-         poetry run pytest
-          --capture=no
-          --override-ini=log_cli=true
-          --override-ini=log_cli_level=INFO
-          --nb_test_file=nbtest_ibis.py
-          test/notebook_test_runner/test_notebooks_in_dss_docker_image.py
+          poetry run pytest
+            --capture=no
+            --override-ini=log_cli=true
+            --override-ini=log_cli_level=INFO
+            --nb-test-file=nbtest_ibis.py
+            test/notebook_test_runner/test_notebooks_in_dss_docker_image.py
         env:
           SAAS_HOST: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_HOST }}
           SAAS_ACCOUNT_ID: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_ACCOUNT_ID }}

diff --git a/test/notebook_test_runner/conftest.py b/test/notebook_test_runner/conftest.py
@@ -3,10 +3,10 @@
 
 def pytest_addoption(parser):
     parser.addoption(
-        "--nb_test_file", action="store", default="2", help="Notebook test file nbtest_*.py"
+        "--nb-test-file", action="store", help="Notebook test file nbtest_*.py"
     )
 
 
 @pytest.fixture
 def nb_test_file(request):
-    return int(request.config.getoption("--nb_test_file"))
+    return str(request.config.getoption("--nb-test-file"))