Common notation #146
Common notation #146
Conversation
|
format! |
|
Strange black complains, but the format action seems to be ok with the formatting. Also my local black seems to be OK with the files. |
| if not operation.get("schema"): | ||
| logging.error("Error Schema missing for Set schema to allow creating views") | ||
| raise KeyError | ||
|
|
||
| return operation["schema"].format(**flatten(value)) + "/" | ||
|
|
||
|
|
||
| def extract_from_operation(operation, value): | ||
| """takes an operation""" | ||
| def extract_from_operation(operation: dict, value) -> dict: |
There was a problem hiding this comment.
What type could value be in this context?
There was a problem hiding this comment.
In the current design it is either are number, string or dict. This should be refactored at some point such that it is only a number or string
src/obr/create_tree.py
Outdated
| @@ -142,7 +165,10 @@ def add_variations( | |||
| parent_job: Job, | |||
| id_path_mapping: dict, | |||
| ) -> list: | |||
There was a problem hiding this comment.
If possible, could you specifiy what type the list elements inherit? I assume operations would be list[str]?
| base_dict = deepcopy(to_dict(parent_job.sp)) | ||
|
|
||
| statepoint = { | ||
| "keys": keys, | ||
| "keys": parse_res["keys"], |
There was a problem hiding this comment.
Is keys always existing in parse_keys ? Or could this potentially throw a KeyError?
There was a problem hiding this comment.
This has always keys, since extract_from_operation always adds them.
Co-authored-by: Lukas Petermann <60653355+lupeterm@users.noreply.github.com>
This PR implements the common notation to allow writing yaml files with key values more compact
Example:
can now be written as
Additionally,