Fix Scheduler mode + add docker compose to readme #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichetof
changed the title
Open
|
Thank you for your thoughtful words and valuable contribution! I’ve gone ahead and merged your fix. As for Docker Compose, I have plans to incorporate a more comprehensive solution in the near future. |
|
Don't we need some sort of volumes in this docker-compose docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Many thanks for your great work, everything works like a charm!
When you attempt to start container on mode
schedulerit doesn't start as we need to passWITH_SCHEDULERenv.This PR fix that.
I added to the readme an example of use with Docker compose