Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v0.2.0 #28

Merged
merged 4 commits into from
Feb 20, 2019
Merged

Prepare release v0.2.0 #28

merged 4 commits into from
Feb 20, 2019

Conversation

josemrb
Copy link
Collaborator

@josemrb josemrb commented Feb 4, 2019

Please let me know what you think

@brolaugh
Copy link

brolaugh commented Feb 4, 2019

resources/PhoneNumberMetadata.xml appears to be out of date compared to Google's repository. Is this intentional?

@josemrb
Copy link
Collaborator Author

josemrb commented Feb 4, 2019

@brolaugh yes, the included file corresponds to the release 8.10.2 of the original lib

@brolaugh
Copy link

brolaugh commented Feb 4, 2019

@brolaugh yes, the included file corresponds to the release 8.10.2 of the original lib

Could you add information in the release about and maybe in the README about which metadata version is being used? That would make it easier to see how updated the repo is since it doesn't follow the same version numbers as the original lib.

Copy link
Member

@szymon-jez szymon-jez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But for the future we should split formatting code and upgrading dependencies in to 2 separate PRs.

idea: In order to keep the formatting we should make our CI check the formatting.

@szymon-jez szymon-jez requested a review from elvanja February 7, 2019 10:18
@szymon-jez szymon-jez merged commit 9d44cad into ex-phone-number:develop Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants