New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#963] [3.0] Chart > 높이 혹은 너비계산시 NaN이 리턴되는 현상 #969

Merged

kdeun1 merged 2 commits into 3.0 from 963_3.0_chart_falsy_value_issue

Dec 8, 2021

Collaborator

jhee564 commented Dec 8, 2021

작업내용

data의 값이 단순 숫자가 아닌 color 프로퍼티를 포함한 {value: undefined, color: '#FFFFFF'} 일 경우를 대비해 value 프로퍼티를 검사하는 로직을 data.value ?? ...에서 hasOwnProperty로 변경
EVUI 버전 업데이트 (47 -> 48)

jhee564 added 2 commits

December 8, 2021 09:55


          [#963] [3.0] Chart > 높이 혹은 너비계산시 NaN이 리턴되는 현상

19f7f0b

#####################
1. data의 값이 단순 숫자가 아닌 color 프로퍼티를 포함한 {value: undefined, color: '#FFFFFF'} 일 경우를 대비해 value 프로퍼티를 검사하는 로직을 hasOwnProperty로 변경


          Update minor version (3.1.47 -> 3.1.48)

eb650d2

kdeun1 approved these changes

View reviewed changes

kdeun1 merged commit 81df18a into 3.0

kdeun1 deleted the 963_3.0_chart_falsy_value_issue branch

December 8, 2021 01:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet