[#734][3.0] Tree 컴포넌트 기능 개선(filtering 기능 추가), TextField 컴포넌트의 searchValue() 수정 #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue() 수정 ########### - Filtering 기능 추가하여 스펙 문서 수정(tree.md), 예제 추가(Default.vue) - Tree, TreeNode 컴포넌트 내에서 스타일 scoped 사용 제거 - filtering 기능 추가 - 검색어가 아예 없을 경우에도 검색이 되어야 하므로 조건 제거(TextField.vue)
caferion
reviewed
Feb 3, 2021
########### - filteredValue를 searchWord로 변경 - 오타 수정 - 선언된 변수 활용하도록 수정
########### - in 연산자 대신 Object.hasOwnProperty.call()을 사용해서 해당 프로퍼티 확인하는 방식으로 수정
caferion
reviewed
Feb 4, 2021
########### - 노드가 많아지면 발생할 수 있는 부하에 대한 피드백 반영, 쓰로틀링 방법을 도입하여 수정
caferion
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###########