[#706][3.0] ContextMenu 컴포넌트 개발 #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2020 15:22
################ - 컨텍스트메뉴의 템플릿 구조를 body에 teleport 시키는 래핑 컴포넌트와 실제 보여지는 항목 UL, LI로 구성된 메뉴리스트 컴포넌트 분리 개발 - nested 구조인 경우 자식을 recusive하게 호출하여 DOM의 depth가 깊어지는 구조 - 모듈 리펙토링 및 JSDoc 작성 - DOCS context menu 예제 및 설명MD 작성 - DOCS context menu 메뉴 router 추가 - DOCS 메인 화면 구조 변경
################ - props의 validator를 추가하여 click속성은 function type으로 children속성은 [] type으로 받을 수 있도록 함
mmindy
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
################