Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1591] Select > Multiple Checkable Select > All Check 초기값 버그 #1593

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[#1591] Select > Multiple Checkable Select > All Check 초기값 버그 #1593

merged 1 commit into from
Jan 24, 2024

Conversation

eedys
Copy link
Contributor

@eedys eedys commented Jan 24, 2024

해결하려는 문제가 무엇인가요?

  • 상위 컴포넌트의 setup 내부에서 정의하지 않고, props로 items(전체 리스트)를 받을 경우 최초 렌더링 시점에 items의 갯수가 0이 되어 all checkbox가 true값으로 세팅되는 버그

어떻게 해결했나요?

  • 선택된 체크박스 갯수가 0일경우 all checkbox false 처리

[#1591] Select > Multiple Checkable Select > All Check 초기값 버그
95eb712 
########################################################################
- 상위 페이지에서 props로 items들을 받을 경우 렌더링 시점에 따라 선택된 item과 전체 item간의 갯수가 각각 0으로 체크되어 all check 값이 true로 되는 버그 수정
@chichoon chichoon merged commit fda2b7f into 3.0 Jan 24, 2024
@jinbekim jinbekim linked an issue Feb 28, 2024 that may be closed by this pull request
Select > Multiple Checkable Select > All Check 초기값 버그 #1591
Closed
@jinbekim jinbekim deleted the 1591-select-all-check branch February 28, 2024 01:10
@jinbekim
Copy link
Collaborator

jinbekim commented Feb 28, 2024 •
edited
Loading

close #1591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chichoon chichoon chichoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select > Multiple Checkable Select > All Check 초기값 버그
3 participants
@eedys @jinbekim @chichoon