[#1323]Line Chart > Zoom 메모리 초기화 #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
################################ [수정내역] - 차트에 사용하는 chartData가 업데이트 시 기존에 메모리와, 브러시 선택 영역이 자동으로 초기화 되던 부분을 useResetZoomMemory(default true) 옵션으로 상황에 따라 차트 데이터가 업데이트 되더라도 줌 메모리와 브러시 선택 영역은 초기화가 되지 않도록 수정.
################################ - seriesList if 조건문 수정
jhee564
added a commit
that referenced
this pull request
Nov 17, 2022
…arn 발생 ##################################### - null은 차트 데이터에서 유의미한 데이터이기 때문에 warning 메시지가 발생할 필요 없어 조건문 삭제함 - Util함수에 JS Docs 추가 - warning 메시지 오탈자 수정
################################ - useResetZoomMemory false 옵션에서 브러시 영역이 보이도록 수정
kdeun1
pushed a commit
that referenced
this pull request
Nov 18, 2022
kdeun1
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
################################
[수정내역]