Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1227] Pie Chart > 차트가 안 보일정도로 브라우저 사이즈를 줄일 시 Error Log 발생 #1228

Merged
merged 1 commit into from
Jun 30, 2022
Merged

[#1227] Pie Chart > 차트가 안 보일정도로 브라우저 사이즈를 줄일 시 Error Log 발생 #1228

merged 1 commit into from
Jun 30, 2022

Conversation

jhee564
Copy link
Collaborator

@jhee564 jhee564 commented Jun 29, 2022 •
edited
Loading

이슈 내용

image

  • Path2D 메소드는 Parameter로 받을 radius 값이 양수이어야 한다는 에러 로그 발생

처리 내용

  • 원의 반지름(radius) 값이 음수로 계산될 경우 draw 로직을 cancel 하도록 예외처리 추가
    • drawPie
    • drawSunbrast

@jhee564
[#1227] Pie Chart > 차트가 안 보일정도로 브라우저 사이즈를 줄일 시 Error Log 발생
bef5e3f 
- 원의 반지름(radius) 값이 음수로 계산될때가 있어 예외 처리 추가함
@kdeun1 kdeun1 merged commit 5a5cd3e into 3.0 Jun 30, 2022
@kdeun1 kdeun1 deleted the 1227_pie_chart_issue branch June 30, 2022 06:17
@jhee564 jhee564 restored the 1227_pie_chart_issue branch July 1, 2022 02:25
@jinbekim jinbekim deleted the 1227_pie_chart_issue branch July 30, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdeun1 kdeun1 kdeun1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhee564 @kdeun1