Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1076] Chart > Pie 차트 Tooltip 기능 추가 #1077

Merged
merged 2 commits into from
Feb 28, 2022
Merged

[#1076] Chart > Pie 차트 Tooltip 기능 추가 #1077

merged 2 commits into from
Feb 28, 2022

Conversation

jhee564
Copy link
Collaborator

@jhee564 jhee564 commented Feb 25, 2022 •
edited
Loading

Before

  1. Tooltip기능 존재하지 않음
  2. highlight 기능 존재하지 않음
    pie

After

  1. Tooltip 기능 추가
  2. Highlight 기능 추가
    pie_after1
    pie_after2
    pie_after3

추가 작업내용

  1. 여러개의 dataset을 표현하는 기능 제거 및 예제 코드 삭제
    image
  2. 모호한 변수명 변경 (type -> seriesIDs)
  3. JS Docs 일부 잘못 기재 되어있던 부분 정정
  4. 기타 리팩토링

@jhee564
[#1076] Chart > Pie 차트 Tooltip 기능 추가
6cc991d 
###################################
1. 차트안에 데이터를 여러개 넣을 수 있는 기능 제거 및 관련 예제 코드 제거
3. Tool tip 기능 추가 및 관련 설명 추가
4. 마우스 오버시 highlight 표시 기능 추가
@jhee564
[#1076] Chart > Pie 차트 Tooltip 기능 추가
c09b46c 
###################################
1. 코드리뷰 피드백 반영
@kdeun1 kdeun1 merged commit 1ca67e3 into 3.0 Feb 28, 2022
@kdeun1 kdeun1 deleted the 1076_chart_pie_add_tooltip_and_highlight branch February 28, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdeun1 kdeun1 kdeun1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhee564 @kdeun1