Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0] EVUI > Window ESC 누르면 닫히게 개선 #994

Closed
sej-dev opened this issue Dec 28, 2021 · 0 comments
Closed

[3.0] EVUI > Window ESC 누르면 닫히게 개선 #994

sej-dev opened this issue Dec 28, 2021 · 0 comments

Comments

@sej-dev
Copy link
Collaborator

sej-dev commented Dec 28, 2021 •
edited
Loading

[ 추가 사항 ] : Window에 ESC 키 누르면 닫히는 기능 추가

  • props에 esc-close 추가
  • 문서에 esc-close 옵션 추가
sej-dev added a commit that referenced this issue Dec 28, 2021
@sej-dev
[#994] [3.0] EVUI > Window ESC 누르면 닫히게 개선
d601cac 
###############
1. Window.vue에 default값 false인 escClose prop 추가
2. uses.js에 esc keydown 이벤트 관리하는 useEscKeydownEvent 추가
sej-dev added a commit that referenced this issue Dec 28, 2021
@sej-dev
[#994] [3.0] EVUI > Window ESC 누르면 닫히게 개선
95facca 
###############
1. Window 문서(window.md)에 esc-close prop 내용 추가
sej-dev added a commit that referenced this issue Dec 28, 2021
@sej-dev
[#994] [3.0] EVUI > Window ESC 누르면 닫히게 개선
edf8396 
###############
1. getZIndexFromElement 함수에서 NaN 로직 보강
2. openWindow -> activeWindow, closeWindow -> inactiveWindow 명칭 변경
3. sequence 관리 함수 제거
4. 불필요한 변수 제거
sej-dev added a commit that referenced this issue Dec 28, 2021
@sej-dev
[#994] [3.0] EVUI > Window ESC 누르면 닫히게 개선
8fc82bf 
###############
1. getZIndexFromElement 함수 NaN 로직 간결하게 정리
sej-dev added a commit that referenced this issue Dec 28, 2021
@sej-dev
[#994] [3.0] EVUI > Window ESC 누르면 닫히게 개선
23b8e49 
###############
1. == -> === 로 변경
mmindy pushed a commit that referenced this issue Dec 28, 2021
@sej-dev
[#994] [3.0] EVUI > Window ESC 누르면 닫히게 개선 (#996)
9279e9a 
- Window.vue에 default값 false인 escClose prop 추가
- uses.js에 esc keydown 이벤트 관리하는 useEscKeydownEvent 추가
- Window 문서(window.md)에 esc-close prop 내용 추가
- getZIndexFromElement 함수에서 NaN 로직 보강 및 정리
@sej-dev sej-dev closed this as completed Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sej-dev