Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for credentials_process #911

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Conversation

JoeyBG
Copy link
Contributor

@JoeyBG JoeyBG commented Oct 18, 2022

Closes #664.

I've been testing it locally for a couple weeks, since I now use 1Password to store my AWS credentials.

I did my best to add clear error messages 🙂!

Here's the relevant AWS documentation : https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-sourcing-external.html

@bernardd
Copy link
Contributor

Hi @JoeyBG
Thanks for the PR, that all looks great. Would you be able to add some docs/examples and some tests to cover the functionality please?
Apologies for the delay getting back to you.

@JoeyBG
Copy link
Contributor Author

JoeyBG commented Nov 21, 2022

Hi @bernardd,

I'll add an example sometime this week - I'm not sure I should add documentation, besides maybe a link to the official AWS doc, since it's basically going to be saying the same thing, and risk being outdated if they change how it works.

I tried adding tests before opening the PR, but I couldn't easily find a way without refactoring the whole module. There don't seem to be any tests for that part. I'll need more guidance from you to proceed.

@bernardd
Copy link
Contributor

You're right - those tests are a bit of a shambles and/or missing entirely. Oh well.
In terms of documentation, just a quick example in the README of how to use this feature would be fine, just under the AWS Key configuration section. Cheers.

@bernardd
Copy link
Contributor

Oh wait, I see - this is a config that lives in the AWS config itself, and this just adds support for it. Okay, nevermind documenting it then :)

@bernardd bernardd merged commit c0b608e into ex-aws:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support credential_process in ~/.aws/config?
2 participants