Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes #124

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Fix crashes #124

merged 4 commits into from
Mar 9, 2024

Conversation

ewjoachim
Copy link
Owner

Closes #123

Fix 2 crashes:

  • Crash if there's no token and no provided changelog url
  • Crash if a release has no title (because GitHub sends None instead of an empty string :( )

Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

@ewjoachim ewjoachim enabled auto-merge March 9, 2024 16:36
@ewjoachim ewjoachim mentioned this pull request Mar 9, 2024
Closed
@ewjoachim ewjoachim merged commit 159c0bb into main Mar 9, 2024
7 checks passed
@ewjoachim ewjoachim deleted the fixes branch March 9, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment variable returns None
1 participant
@ewjoachim