Implement proper EVM-style types #6
Merged
+127
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelang
force-pushed
the
refactor-types
branch
from
84c014e
to
c6934e9
Compare
jakelang
force-pushed
the
refactor-types
branch
from
c6934e9
to
e3a819f
Compare
axic
reviewed
Aug 15, 2018
axic
reviewed
Aug 15, 2018
axic
reviewed
Aug 15, 2018
axic
reviewed
Aug 15, 2018
|
Needs to b rebased. |
jakelang
force-pushed
the
refactor-types
branch
from
291f1ca
to
73ad8e4
Compare
|
rebased |
jakelang
force-pushed
the
refactor-types
branch
from
73ad8e4
to
c1da869
Compare
|
rebased again |
jakelang
force-pushed
the
refactor-types
branch
2 times, most recently
from
4983e19
to
6f72842
Compare
axic
reviewed
Aug 17, 2018
axic
changed the title
axic
reviewed
Aug 17, 2018
axic
reviewed
Aug 17, 2018
axic
reviewed
Aug 17, 2018
jakelang
force-pushed
the
refactor-types
branch
from
348db3a
to
8543fd3
Compare
jakelang
commented
Aug 20, 2018
jakelang
force-pushed
the
refactor-types
branch
from
1cf3a90
to
ab6546d
Compare
|
Rebased |
jakelang
force-pushed
the
refactor-types
branch
from
8e90b7d
to
1998330
Compare
axic
reviewed
Nov 29, 2018
| @@ -88,6 +88,29 @@ fn unsafe_alloc_buffer(len: usize) -> Vec<u8> { | |||
| ret | |||
| } | |||
|
|
|||
| #[derive(Default, Copy, Clone)] | |||
| pub struct Uint128 { | |||
| pub bytes: [u8; 16], | |||
There was a problem hiding this comment.
Can we collapse these into "single member" structs?
Uint128([u8; 16]) ?
jakelang
force-pushed
the
refactor-types
branch
3 times, most recently
from
6283cd1
to
ce4fb31
Compare
axic
reviewed
Nov 29, 2018
axic
reviewed
Nov 29, 2018
axic
reviewed
Nov 29, 2018
jakelang
force-pushed
the
refactor-types
branch
3 times, most recently
from
00ce4ac
to
b748004
Compare
axic
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the types
u128,u160, andu256with the aliasesValue,Address, andHashrespectively.This allows us to easily implement high-level functionality for EVM types in the Rust API, to be used by contract developers.
closes #4