Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vanilla-wabt #110

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Add vanilla-wabt #110

merged 1 commit into from
Jun 29, 2020

Conversation

hugo-dc
Copy link
Member

@hugo-dc hugo-dc commented Jun 24, 2020 •
edited by axic
Loading

  • Added vanilla-wabt
  • Rerun the benchmarks and regenerated the python notebook
  • Included charts changed when running the python notebook, realized some charts are only shown in the notebook but not saved to a file, created an issue for this
  • For one of the generated charts the wasm results are missing, this is due to a missing rust-code for mul256, also created an issue
  • still pending to push the bench image to dockerhub.

Closes #76.

@hugo-dc hugo-dc marked this pull request as ready for review June 25, 2020 18:14
@hugo-dc hugo-dc requested review from axic and jwasinger June 25, 2020 18:14
@axic
Copy link
Member

axic commented Jun 25, 2020

To be honest I'd prefer to call this wabt and the current one something else (turbo-wabt, soup-wabt, etc.), but we can do that in a follow up change.

axic
axic reviewed Jun 25, 2020
View reviewed changes
wasm-engines/docker/vanilla-wabt.Dockerfile Outdated
@@ -0,0 +1,12 @@
FROM ewasm/llvm-10:1 as build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM ewasm/llvm-10:1 as build
FROM ewasm/llvm-10:1 AS build

@axic
Copy link
Member

axic commented Jun 29, 2020

Please rebase, and also include it in the README.

@jwasinger jwasinger force-pushed the vanilla-wabt branch 4 times, most recently from 07b8ff6 to b883751 Compare June 29, 2020 22:20
@jwasinger @hugo-dc
add vanilla-wabt
d463cf2 
Co-authored-by: Jose Hugo De la cruz Romero <jhugodc@gmail.com>
@jwasinger jwasinger mentioned this pull request Jun 29, 2020
Open
@jwasinger jwasinger merged commit ac9b236 into ewasm:master Jun 29, 2020
@jwasinger jwasinger mentioned this pull request Jun 30, 2020
Closed
@axic axic mentioned this pull request Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

@jwasinger jwasinger Awaiting requested review from jwasinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include vanilla wabt in wasm-engines (next to "ewasm-wabt")
3 participants
@hugo-dc @axic @jwasinger